Fix: Prevent infinite loop that leads to "ran out of pool" error in Astar obstacle checking#47
Open
long-tree wants to merge 1 commit intoZJU-FAST-Lab:mainfrom
Open
Fix: Prevent infinite loop that leads to "ran out of pool" error in Astar obstacle checking#47long-tree wants to merge 1 commit intoZJU-FAST-Lab:mainfrom
long-tree wants to merge 1 commit intoZJU-FAST-Lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-This fix replaces an opaque system crash with a clear, actionable error message, which is the correct intended behavior.
checkOccupancy(Index2Coord(start_idx))instead ofcheckOccupancy(Index2Coord(end_idx))when adjusting the end point.occ = -1), the conditionwhile (checkOccupancy(Index2Coord(end_idx))would continue because-1is truthy in C++ , causing endless adjustments.-I have tested in tracking_ws. Before the fix, the code would fail with an obscure
ran out of pool, which was difficult to trace back to its root cause. After the fix, the function logging a clear message:[Astar] End point outside the map region. This fix replaces an opaque system crash with a clear, actionable error message, which is the correct intended behavior.