Alt itest vscode improvements#1
Draft
ZZiigguurraatt wants to merge 3 commits intogeneral_itest_improvementsfrom
Draft
Alt itest vscode improvements#1ZZiigguurraatt wants to merge 3 commits intogeneral_itest_improvementsfrom
ZZiigguurraatt wants to merge 3 commits intogeneral_itest_improvementsfrom
Conversation
a8c19d5 to
c578fc5
Compare
9c464a2 to
bb21c3c
Compare
Owner
Author
|
@gijswijs, would appreciate if you could take a look. github is not allowing me to add you as a reviewer for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to find the best combination of options vs lightninglabs#990. Would like some review on this, but github is not showing the diff properly. Here is the correct diff of the file of interest: