Skip to content

Conversation

@ZZiigguurraatt
Copy link
Owner

@ZZiigguurraatt ZZiigguurraatt commented Feb 27, 2025

Trying to find the best combination of options vs lightninglabs#990. Would like some review on this, but github is not showing the diff properly. Here is the correct diff of the file of interest:

$ git diff general_itest_improvements alt_itest_improvements .vscode/launch.json
diff --git a/.vscode/launch.json b/.vscode/launch.json
index 3975819..a03f65e 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -12,19 +12,21 @@
       "preLaunchTask": "reset before itest",
       "program": "${workspaceFolder}/itest",
       "env": {
-        "CGO_ENABLED": "0",
+              "GOEXPERIMENT": "loopvar",
+              "GO111MODULE": "on"
       },
       "args": [
         "-test.v",
         "-test.run=TestLightningTerminal/test_custom_channels",
-        "-logoutput",
+        "-loglevel=trace",
+        "-btcdexec=./btcd-itest",
         "-logdir=${workspaceFolder}/itest/.logs",
         "-litdexec=${workspaceFolder}/itest/litd-itest",
       ],
       "buildFlags": [
-        "-ldflags=-X github.com/lightningnetwork/lnd/build.RawTags=chainrpc,walletrpc,signrpc,invoicesrpc,autopilotrpc,watchtowerrpc,twclientrpc -X github.com/lightningnetwork/lnd/build.Commit=lightning-terminal-v0.4.0-alpha -X github.com/lightninglabs/loop.Commit=localbuild -X github.com/lightninglabs/pool.Commit=localbuild -X github.com/lightninglabs/lightning-terminal.Commit=localbuild",
-        "-tags=dev integration itest lowscrypt litd autopilotrpc signrpc walletrpc chainrpc invoicesrpc watchtowerrpc neutrinorpc peersrpc",
+              "-tags=dev integration itest autopilotrpc routerrpc signrpc verrpc walletrpc chainrpc invoicesrpc watchtowerrpc wtclientrpc peersrpc btcd monitoring",
       ],
+      "hideSystemGoroutines": true,
     },
     {
       "name": "Debug Tests",
@@ -47,4 +49,4 @@
       "disableOptimisticBPs": true
     }
   ]
-}
\ No newline at end of file
+}

@ZZiigguurraatt ZZiigguurraatt force-pushed the general_itest_improvements branch from 9c464a2 to bb21c3c Compare February 27, 2025 17:25
@ZZiigguurraatt ZZiigguurraatt changed the title Alt itest improvements Alt itest vscode improvements Feb 27, 2025
@ZZiigguurraatt
Copy link
Owner Author

@gijswijs, would appreciate if you could take a look. github is not allowing me to add you as a reviewer for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants