Conversation
d563ca3 to
9970cd2
Compare
|
eh, I think I'm OK with taking out I'm also increasingly keen on the reconstructed-as-if-one-run view (cf #45 (comment)), but that's definitely a future PR. |
1471378 to
cdec17c
Compare
cdec17c to
51d7fc8
Compare
|
pycrunch/pytrace should be doable to update. I'll do that, and then we should ship this, since it also fixes compatibility with newer hypothesis versions (hopefully the last of those now that namings have settled down). |
65c0df7 to
b8c85e7
Compare
Zac-HD
left a comment
There was a problem hiding this comment.
I've spun this up locally, and it looks great! I'll leave some more notes with followups below, but my inclination now is to merge this and take smaller incremental PRs to continue improving 😁
There was a problem hiding this comment.
thoughts for later
- we could test that this interface stays in sync with the Python definition
- actually, since we're writing to a database, if it ever changes (likely!) we'd better be prepared to read older and perhaps newer versions...
| previous_data = None | ||
| while True: | ||
| await poll_database() | ||
| # TODO use hypothesis db listening |
There was a problem hiding this comment.
Soon! (not in this PR though, it's already Large)
| middleware = [ | ||
| # allow pytrace to request pycrunch recordings for the web interface | ||
| Middleware( | ||
| CORSMiddleware, | ||
| allow_origins=["https://app.pytrace.com"], |
There was a problem hiding this comment.
Noting for the future: some users will want to self-host this; so we'll eventually need a corresponding config option. (I don't think we can ship it, since the webapp is not open source)
|
Random notes from playing around with this:
|
|
lots of good stuff in that list, will work through it 👍. Brief notes:
|
Closes #7, #17. Most of the react code was written by claude, and touched up by me.
pyproject.tomlfor building, with a custom build hook, and am requiring the developer havenpminstalled in their host system to build.dist/*as part of the build step and am uploading that as part of the compiled.whl.It should just work ™️ when installed normally (untested).TODO:
since new covon test overview pageThis dashboard is still missing some stuff compared to the existing one, but it is runnable 😄