Skip to content

Fix issues when running with KSP2#93

Merged
ZacSweers merged 8 commits intoZacSweers:mainfrom
WhosNickDoglio:ndoglio/k2-enum-poet
Nov 22, 2025
Merged

Fix issues when running with KSP2#93
ZacSweers merged 8 commits intoZacSweers:mainfrom
WhosNickDoglio:ndoglio/k2-enum-poet

Conversation

@WhosNickDoglio
Copy link

@WhosNickDoglio WhosNickDoglio commented Nov 5, 2025

We need changes from these PRs (square/kotlinpoet#1885 & square/kotlinpoet#1956) to fix an issue with KSP2.

https://github.com/square/kotlinpoet/releases/tag/1.18.0
https://github.com/square/kotlinpoet/releases/tag/1.18.1
https://github.com/square/kotlinpoet/releases/tag/2.0.0

Everything passes for me locally except the Gradle intergration tests that fail but those also fail on main in my testing. All non-dependency update changes were related to KspContributionMergerTest.typealiases are followed failing.

No new tests were added since currently none of the test suites run using KSP2.

Fixes #90

@WhosNickDoglio WhosNickDoglio changed the title Update KotlinPoet to 1.18.1 Fix issues when running with KSP2 Nov 12, 2025
@WhosNickDoglio WhosNickDoglio force-pushed the ndoglio/k2-enum-poet branch 2 times, most recently from 970a3df to fe3ab1b Compare November 18, 2025 20:11
@ZacSweers ZacSweers marked this pull request as ready for review November 18, 2025 21:21
@ZacSweers ZacSweers marked this pull request as draft November 18, 2025 21:21
@WhosNickDoglio WhosNickDoglio marked this pull request as ready for review November 18, 2025 21:33
@ZacSweers
Copy link
Owner

@WhosNickDoglio I've only loosely been following, what's up with the two failing checks?

@WhosNickDoglio
Copy link
Author

WhosNickDoglio commented Nov 18, 2025

I've only loosely been following, what's up with the two failing checks?

The failing tests in "Gradle integration tests" fail on main for me and I couldn't get the "Instrumentation tests" test job to run on CI. I attempted to fix the actions/cache issue at one point but that pointed to a different issue with emulators and felt out of scope of this PR to get working.

@ZacSweers
Copy link
Owner

I'm happy to take PRs but I can't really take any that fail CI :/

@WhosNickDoglio
Copy link
Author

I'm sorry I'm confused. Both the jobs failing are currently broken in main. Are you suggesting I fix these unrelated issues before my PR could be reviewed?

@ZacSweers
Copy link
Owner

ZacSweers commented Nov 22, 2025

Only the gradle integration test is failing in main. This PR appears to introduce a new failure.

Main

CleanShot 2025-11-21 at 20 24 12@2x

This PR
CleanShot 2025-11-21 at 20 24 23@2x

I'm willing to ignore the existing failure, but yeah, new failures aren't helpful unless I'm missing something about what's happening on main?

@ZacSweers
Copy link
Owner

Ok let me look at these, I see it's github actions failures now that I'm back at a computer

@WhosNickDoglio
Copy link
Author

Thank you! That's probably my bad for not explaining that better in the PR description. If those are actually broken due to my changes I will fix them 👍

@ZacSweers ZacSweers merged commit f57d3b6 into ZacSweers:main Nov 22, 2025
15 checks passed
@WhosNickDoglio WhosNickDoglio deleted the ndoglio/k2-enum-poet branch November 24, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KSP2 mulibinding generated code is missing an import

2 participants