fix(audio): ensure directories are created on first run#317
Open
aadidesign wants to merge 1 commit intoZackriya-Solutions:mainfrom
Open
fix(audio): ensure directories are created on first run#317aadidesign wants to merge 1 commit intoZackriya-Solutions:mainfrom
aadidesign wants to merge 1 commit intoZackriya-Solutions:mainfrom
Conversation
On first installation, audio recordings were not saved because the .checkpoints directory didn't exist and IncrementalAudioSaver::new() would fail silently. The recording continued but audio chunks were discarded. This fix: - Creates .checkpoints directory if missing in IncrementalAudioSaver - Creates base recordings directory if missing in RecordingSaver - Adds defensive directory creation to prevent data loss on first use Fixes Zackriya-Solutions#307
Collaborator
|
Thank you for contributing. will review the PR and share updates. |
Collaborator
|
Hi, We tried to find the root cause of #307 and found out that it was related to ffmpeg downloading/failing in the runtime. Thank you |
Author
|
Hi, thank you for the clarification! I appreciate you explaining the actual root cause - I wasn't aware it was related to ffmpeg downloading/failing at runtime. That makes sense why the issue only occurs on first run. Would you like me to:
Either way, I learned a lot from investigating this issue. Happy to help with anything else if needed! |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.checkpointsdirectory defensively inIncrementalAudioSaver::new()RecordingSaver::initialize_meeting_folder()Root Cause
On first run,
IncrementalAudioSaver::new()checked if.checkpointsexisted and returned an error if it didn't. This error was caught but recording continued without the saver initialized, causing audio chunks to be silently discarded.Changes
| File | Change |
|
frontend/src-tauri/src/audio/incremental_saver.rs| Create.checkpointsdirectory if missing instead of failing ||
frontend/src-tauri/src/audio/recording_saver.rs| Create base recordings directory if missing before initialization |Test Plan
Fixes #307