Feature/macos intel support#334
Draft
blime4 wants to merge 35 commits intoZackriya-Solutions:devtestfrom
Draft
Conversation
added 30 commits
February 4, 2026 22:58
… builds Fixed critical issue where the "both" build option attempted to use the non-existent Tauri CLI --universal flag. The workflow now builds both architectures separately when "both" is selected. Changes: - Split single "Build Tauri app" steps into separate Apple Silicon and Intel builds - Updated conditional logic to run both builds when build-arch is "both" - Fixed verification steps to handle both architecture directories - Updated artifact upload to include both aarch64 and x86_64 targets - Enhanced build summary to show separate counts for each architecture Technical details: - Apple Silicon builds: target/aarch64-apple-darwin/ - Intel builds: target/x86_64-apple-darwin/ - Each architecture gets its own DMG, .app bundle, and signature files - No universal binary creation (requires lipo, deferred to future work) This fix ensures the "both" option will actually work instead of failing with an unknown flag error.
…h builds The term 'Universal' in macOS specifically means a single binary containing both architectures (created via lipo -create). Our 'both' option builds separate binaries for each architecture, so 'Multi-Arch' is the accurate terminology.
The "rustup install target" step was attempting to install 'universal-apple-darwin' as a Rust target, which is invalid because it's a Tauri meta-target, not a Rust target. This caused the workflow to fail with: error: target 'universal-apple-darwin' is not a valid target Fixed by adding '&& inputs.target != 'universal-apple-darwin'' to the condition. The required Rust targets (aarch64-apple-darwin and x86_64-apple-darwin) are already installed by the "Install Rust stable" step when building for universal macOS. This ensures the workflow properly handles all macOS targets: - aarch64-apple-darwin: rustup installs target - x86_64-apple-darwin: rustup installs target - universal-apple-darwin: skipped (targets already installed earlier)
Metal framework is available on both Apple Silicon and Intel-based Macs. While Apple Silicon has additional CoreML optimizations, Metal GPU acceleration works perfectly fine on Intel Macs for ML workloads.
- Update macOS installation instructions to mention both Apple Silicon and Intel builds - Add comprehensive system requirements for macOS including Intel Macs - Document GPU acceleration performance differences between Apple Silicon and Intel Macs - Add performance comparison table in GPU_ACCELERATION.md - Include Metal verification command for macOS users
This workflow allows testing Intel Mac builds without requiring Apple code signing certificates. Useful for validation in forks.
Updated @tauri-apps/api from v2.6.0 to v2.10.1 Updated @tauri-apps/plugin-updater from v2.3.0 to v2.10.0 Updated @tauri-apps/cli from v2.1.0 to v2.1.1 This fixes the version mismatch error during tauri build.
Updated tauri from 2.6.2 to 2.10.1 Updated tauri-plugin-updater from 2.3.0 to 2.10.0 Updated tauri-plugin-log from 2.6.0 to 2.10.0 This matches the npm package versions (@tauri-apps/api v2.10.1, @tauri-apps/plugin-updater v2.10.0) and resolves the version mismatch error during tauri build.
tauri-plugin-log v2.10.0 does not exist on crates.io. Latest available version is v2.8.0.
Added pull_request trigger to build-test and build-devtest workflows. Tests will now automatically run when: - PR is created or updated - Changes are made to workflows, frontend code, or Tauri code This allows automatic validation of changes without manual workflow dispatch.
The Tauri build requires llama-helper-x86_64-apple-darwin binary to exist. Added steps to build llama-helper with Metal GPU support before the main Tauri build step.
Set TAURI_BUNDLE_CREATE_UPDATER_ARTIFACTS=false to skip updater .sig file creation which requires TAURI_SIGNING_PRIVATE_KEY. This allows the build to complete successfully for testing without requiring the private signing key.
Added pull_request event types [opened, synchronize, reopened] Added push event trigger for feature/macos-intel-support branch Now Actions will automatically run when: - PR is created or updated (synchronize event) - New commits are pushed to feature/macos-intel-support branch
Modified trigger from pull_request to pull_request_target so it won't run on feature branch PRs which don't have access to required secrets. Build Test workflow requires code signing secrets which are not available in PR testing. Build and Test - DevTest will handle automatic PR testing instead (no code signing).
Set TAURI_SIGNING_PRIVATE_KEY to empty string if secret not available Set TAURI_BUNDLE_CREATE_UPDATER_ARTIFACTS to false when no private key exists This allows builds to complete in test workflows without requiring TAURI_SIGNING_PRIVATE_KEY environment variable.
…e key exists This prevents the updater artifact creation error in PR testing workflows where sign-binaries=true but TAURI_SIGNING_PRIVATE_KEY is not available.
…ct error Set sign-binaries to false in test workflow since: 1. Test builds don't need code signing 2. Avoids 'A public key has been found, but no private key' error 3. build.yml will now skip all signing and updater artifact creation
Author
|
fix : #77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Intel-based Macs alongside the existing Apple Silicon (ARM64) support.
Related Issue
[Link to the issue this PR addresses (e.g., "Fixes #123")]
Type of Change
Testing
Documentation
Checklist
Screenshots (if applicable)
[Add screenshots here if your changes affect the UI]
Additional Notes
[Add any additional information that might be helpful for reviewers]