Skip to content

Add explainer message about hidden "finish editing" button #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pwbriggs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add explainer message about hidden "finish editing" button #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion static/js/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const editBackBtn = document.querySelector("#view-edit .btn-back")
const editReloadBtn = document.querySelector("#view-edit .btn-reload")
const editTags = document.getElementById("edit-tags")
const editWarnings = document.getElementById("edit-warnings")
const editFixToSubmit = document.getElementById("fix-to-continue")
const editSubmitBtn = document.querySelector("#view-edit .btn-next")
const sumitBackBtn = document.querySelector("#view-submit .btn-back")
const routeSummary = document.getElementById("route-summary")
Expand Down Expand Up @@ -130,6 +131,7 @@ export const processRouteWarnings = (data) => {
if (activeView === "submit") switchView("edit")

editSubmitBtn.classList.add("d-none")
editFixToSubmit.classList.add("d-none")

editWarnings.innerHTML = ""
let highestSeverityLevel = 0
Expand Down Expand Up @@ -201,7 +203,10 @@ export const processRouteWarnings = (data) => {

editSubmitBtn.classList.toggle("mt-2", data.warnings.length > 0)

if (highestSeverityLevel === 0) editSubmitBtn.classList.remove("d-none")
if (highestSeverityLevel === 0) {
editSubmitBtn.classList.remove("d-none")
editFixToSubmit.classList.add("d-none")
}
}

const unload = () => {
Expand Down
4 changes: 4 additions & 0 deletions templates/_menu.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@
<div class="actions text-end">
<button class="btn btn-primary btn-next w-100 d-none">Finish editing</button>
</div>

<i id="fix-to-continue" class="d-none">
Fix the errors above to upload
</i>
</div>
</div>

Expand Down