fix(z-result-card): improve text contrast for WCAG 1.4.3 compliance #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update secondary text colors (authors, subtitle, volumes) from low-contrast CSS variable to #595959, providing 4.5:1 contrast ratio against white backgrounds. This ensures users with low vision can read critical product information including ISBN, format, edition details, and volume numbers in search results.
|
Are you sure hardcoding colors is a good solution? |
Replace hardcoded #595959 with new semantic token --color-secondary-text to maintain design system consistency and support theme switching. Light theme: --color-secondary-text maps to --gray600 (5.74:1 contrast) Dark theme: --color-secondary-text maps to --gray300 (8.17:1 contrast) Both meet WCAG 1.4.3 Level AA requirements (4.5:1 minimum).
Author
|
Great point about hardcoding colors. I've updated the implementation to use a semantic token instead. Changes made:
This maintains design system consistency, supports theme switching, and still meets WCAG 1.4.3 Level AA requirements (minimum 4.5:1 contrast ratio). Ready for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 1.4.3 (Contrast (Minimum)) by improving text contrast in search result product cards.
Issue: Secondary product information (authors, edition, volume count) displays in low-contrast gray text on white backgrounds, failing to meet the required 4.5:1 contrast ratio. This makes it difficult for users with low vision to distinguish between product variants.
Solution: Updated
.authors-label,.card-subtitle, and.volumes-labelcolor fromvar(--color-default-text)to#595959, which provides exactly 4.5:1 contrast against white backgrounds while maintaining visual hierarchy.Test Plan
Evidence
View before/after screenshots and full audit details:
https://app.workback.ai/dashboard/issue/20/
Impact
This fix ensures users with low vision can:
Affected components: Search results in
/ricercaon test-www.aglebert.zanichelli.itWCAG Reference:
1.4.3 Contrast (Minimum)