fix(skip-link): ensure skip link is visible when focused #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add :focus-within pseudo-class to make skip navigation link visible when keyboard users tab to it. Previously the link remained off-screen even when focused, preventing keyboard-only users from using it effectively. This fixes WCAG 2.4.1 (Bypass Blocks) compliance by ensuring the skip link becomes visible on focus, allowing users to bypass repetitive navigation elements.
Author
|
Fixes Workback.ai accessibility issue #131 (WCAG 2.4.1 - Bypass Blocks). Evidence and testing: https://app.workback.ai/dashboard/issue/131/ |
Author
|
Fixed prettier formatting check by updating CONTRIBUTING.md formatting. CI should pass now. |
Author
|
All CI checks are now passing. Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 2.4.1 (Bypass Blocks) by ensuring the skip navigation link becomes visible when keyboard users tab to it.
Issue: The skip-to-content link was permanently positioned off-screen (
left: -100%) and never became visible even when focused, preventing keyboard-only users from using it effectively.Solution: Added
:focus-withinpseudo-class to the CSS selector so the skip link appears when any child link receives focus.Technical Details
The original CSS only used
:host:focus, but this doesn't work for web components because:<a>element inside the shadow DOM:hostelement itself never receives focus:focus-withinpseudo-class properly detects when descendants are focusedTest Plan
Evidence
Before/after testing demonstrates the skip link now appears when focused, meeting WCAG 2.4.1 requirements.
WCAG Reference:
2.4.1 Bypass Blocks