fix (mifare, non-breaking): ReadNDEF should return all kinds of records present#2
Merged
wizzomafizzo merged 1 commit intoZaparooProject:mainfrom Aug 14, 2025
Conversation
…ds present At the moment it attempts to parse the first text only record which will fail (no NDEF data) if the tag contains other kinds of records e.g. a URI exclusively
Contributor
Author
|
ZaparooProject/zaparoo-core#312 I see you have a PR that will use this library, Let me know if it potentially breaks something there. Though on first look, it seems no. |
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment it attempts to parse the first text only record which will fail (no NDEF data) if the tag contains other kinds of records e.g. a URI exclusively