Add device path ignore functionality to DetectAll#6
Merged
wizzomafizzo merged 1 commit intomainfrom Aug 14, 2025
Merged
Conversation
- Add IgnorePaths field to detection.Options struct - Implement IsPathIgnored function with case-insensitive path matching - Update all transport detectors (UART, I2C, SPI) to respect ignore list - Add comprehensive tests for path matching including edge cases - Support Unix paths (/dev/ttyUSB0), Windows paths (COM2), and transport-specific formats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to specify device paths that should be explicitly ignored during PN532 detection, preventing aggressive probing of sensitive devices.
Changes
IgnorePathsfield todetection.OptionsstructIsPathIgnored()function with case-insensitive path matching/dev/ttyUSB0), Windows paths (COM2), and transport-specific formatsUsage Example
Key Features
Test Coverage
Fixes the issue where DetectAll could be too aggressive even with existing safety levels.