Open
Conversation
FJiskra
force-pushed
the
PES-2876_permissions-update
branch
from
64ded3f to
c121428
Compare
zemekoule
changed the title
Karpec
suggested changes
Aug 5, 2025
Karpec
suggested changes
Aug 6, 2025
FJiskra
force-pushed
the
PES-2876_permissions-update
branch
from
bc9c1f1 to
74d37e3
Compare
…PermissionHelper for improved clarity and maintainability
FJiskra
force-pushed
the
PES-2876_permissions-update
branch
from
74d37e3 to
c09000c
Compare
Karpec
suggested changes
Aug 8, 2025
added 2 commits
August 11, 2025 10:58
…serEditOrders for improved clarity
…ndency injection for improved maintainability
Karpec
approved these changes
Aug 11, 2025
| $tabPermissionRole = 'ROLE_MOD_TAB_' . strtoupper($section) . '_' . strtoupper($permission === 'view' ? 'READ' : 'UPDATE'); | ||
| $tabRoleId = $this->findAuthorizationRoleId($tabPermissionRole); | ||
| if ($tabRoleId !== null) { | ||
| return $this->hasAccessPermission($context->employee->id_profile, $tabRoleId, self::ACCESS_TYPE_TAB); |
Contributor
There was a problem hiding this comment.
Chápu kód správně, že se nejprve kontroluje oprávnění k modulu (MOD_MODULE) a potom ke Controlleru (MOD_TAB)?
Contributor
Author
There was a problem hiding this comment.
Ano. Je to udělané, tak aby to fungovalo.
| } else { | ||
| $this->tpl_view_vars['carrierHelper'] = $carrierHelper->getHtml(); | ||
| } | ||
| $this->tpl_view_vars['carrierHelper'] = $carrierHelper->getHtml(); |
Contributor
There was a problem hiding this comment.
Proč je tato změna potřeba?
Contributor
Author
There was a problem hiding this comment.
Aby se zobrazoval obsah stránky pokud dojde k chybě.
…roved query handling
…better encapsulation
…er::postProcess()
Karpec
force-pushed
the
PES-2876_permissions-update
branch
from
b7d7478 to
44ca79d
Compare
…r dependency management
…r better dependency management
…Service for improved modularity
Karpec
force-pushed
the
PES-2876_permissions-update
branch
from
9be9100 to
76b4611
Compare
…ionFormService for improved modularity
…roved query handling
jan-potuznik-z
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.