Conversation
|
Nit: This would allow composing capabilities from a single file: # Just Zebra
docker compose up -d
# Zebra + mining pool
docker compose --profile mining up -d
# Zebra + mining pool + CPU miner
docker compose --profile mining --profile miner up -d
# Zebra + observability
docker compose --profile monitoring up -d
# Everything
docker compose --profile mining --profile miner --profile monitoring up -dThis is the pattern used in Z3 for the monitoring stack and avoids duplicating the zebra service definition across multiple compose files. Not blocking for this PR; just flagging the direction in case we'd like to start consolidating the Docker compose |
This mining setup is not something we'd support in production. It's just a forge for devs to bash on, so keeping it separate works better. |
gustavovalverde
left a comment
There was a problem hiding this comment.
utACK.
Just need CI docs fix
Merge Queue Status
This pull request spent 11 minutes 9 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
Motivation
Follow-up Work
PR Checklist