Skip to content

add: Dockerized mining setup#10301

Merged
mergify[bot] merged 5 commits intomainfrom
dockerize-mining
Apr 8, 2026
Merged

add: Dockerized mining setup#10301
mergify[bot] merged 5 commits intomainfrom
dockerize-mining

Conversation

@upbqdn
Copy link
Copy Markdown
Member

@upbqdn upbqdn commented Feb 10, 2026

Motivation

Follow-up Work

PR Checklist

  • The PR name is suitable for the release notes.
  • The PR follows the contribution guidelines.
  • The library crate changelogs are up to date.
  • The solution is tested.
  • The documentation is up to date.

@gustavovalverde
Copy link
Copy Markdown
Member

Nit:nheqminer already uses profiles: [miner]. A consideration (doesn't need to be this PR): redis and s-nomp could also be placed behind a profiles: [mining] in the main docker/docker-compose.yml, rather than living in a separate docker/mining/ directory with its own compose file.

This would allow composing capabilities from a single file:

# Just Zebra
docker compose up -d

# Zebra + mining pool
docker compose --profile mining up -d

# Zebra + mining pool + CPU miner
docker compose --profile mining --profile miner up -d

# Zebra + observability
docker compose --profile monitoring up -d

# Everything
docker compose --profile mining --profile miner --profile monitoring up -d

This is the pattern used in Z3 for the monitoring stack and avoids duplicating the zebra service definition across multiple compose files.

Not blocking for this PR; just flagging the direction in case we'd like to start consolidating the Docker compose

@oxarbitrage oxarbitrage added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Mar 11, 2026
@upbqdn
Copy link
Copy Markdown
Member Author

upbqdn commented Apr 7, 2026

Nit:nheqminer already uses profiles: [miner]. A consideration (doesn't need to be this PR): redis and s-nomp could also be placed behind a profiles: [mining] in the main docker/docker-compose.yml, rather than living in a separate docker/mining/ directory with its own compose file.

This would allow composing capabilities from a single file:

# Just Zebra
docker compose up -d

# Zebra + mining pool
docker compose --profile mining up -d

# Zebra + mining pool + CPU miner
docker compose --profile mining --profile miner up -d

# Zebra + observability
docker compose --profile monitoring up -d

# Everything
docker compose --profile mining --profile miner --profile monitoring up -d

This is the pattern used in Z3 for the monitoring stack and avoids duplicating the zebra service definition across multiple compose files.

Not blocking for this PR; just flagging the direction in case we'd like to start consolidating the Docker compose

This mining setup is not something we'd support in production. It's just a forge for devs to bash on, so keeping it separate works better.

@upbqdn upbqdn requested a review from gustavovalverde April 7, 2026 20:41
gustavovalverde
gustavovalverde previously approved these changes Apr 8, 2026
Copy link
Copy Markdown
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

Just need CI docs fix

@mergify mergify bot added the queued label Apr 8, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 8, 2026

Merge Queue Status

  • Entered queue2026-04-08 09:52 UTC · Rule: batched
  • Checks skipped · PR is already up-to-date
  • Merged2026-04-08 10:03 UTC · at fc4882ae96a1f292d8e9742b403c9ef0f8b9301c

This pull request spent 11 minutes 9 seconds in the queue, including 2 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by >= 1 [🛡 GitHub repository ruleset rule PR Requirements]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub repository ruleset rule PR Requirements]
  • #review-threads-unresolved = 0 [🛡 GitHub repository ruleset rule PR Requirements]
  • any of [🛡 GitHub repository ruleset rule PR Requirements]:
    • check-success = test crate build success
    • check-neutral = test crate build success
    • check-skipped = test crate build success
  • any of [🛡 GitHub repository ruleset rule PR Requirements]:
    • check-success = lint success
    • check-neutral = lint success
    • check-skipped = lint success
  • any of [🛡 GitHub repository ruleset rule PR Requirements]:
    • check-success = test success
    • check-neutral = test success
    • check-skipped = test success

@mergify mergify bot merged commit a53c263 into main Apr 8, 2026
49 checks passed
@mergify mergify bot deleted the dockerize-mining branch April 8, 2026 10:03
@mergify mergify bot removed the queued label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Dockerized mining setup

3 participants