fix: Subtract Founders' Reward from block subsidy#10338
Open
Conversation
conradoplg
reviewed
Feb 23, 2026
Comment on lines
+482
to
+489
| founders_reward: Amount<NonNegative>, | ||
| funding_streams: &HashMap<FundingStreamReceiver, Amount<NonNegative>>, | ||
| ) -> Result<Amount<NonNegative>, amount::Error> { | ||
| let total_funding_stream_amount: Result<Amount<NonNegative>, _> = | ||
| funding_stream_values(height, network, expected_block_subsidy)? | ||
| .values() | ||
| .sum(); | ||
| let funding_streams_sum = funding_streams | ||
| .values() | ||
| .sum::<Result<Amount<NonNegative>, _>>()?; | ||
|
|
||
| expected_block_subsidy - total_funding_stream_amount? | ||
| expected_block_subsidy - founders_reward - funding_streams_sum |
Collaborator
There was a problem hiding this comment.
Is there a particular reason why founders_rewards and funding_streams are arguments instead of being computed inside the function?
My main reason for asking is that this is breaking API change which will require major bumps in most Zebra crates, so it would be better to avoid it unless absolutely necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Tests
AI Disclosure
PR Checklist