fix: resolve non-constant IconData preventing icon font tree-shaking#427
Open
ps9310 wants to merge 1 commit intoZebraDevs:mainfrom
Open
fix: resolve non-constant IconData preventing icon font tree-shaking#427ps9310 wants to merge 1 commit intoZebraDevs:mainfrom
ps9310 wants to merge 1 commit intoZebraDevs:mainfrom
Conversation
Add iconsRound and iconsSharp codePoint lookup maps to zeta_icons so that IconExtensions.apply() returns pre-existing const IconData values instead of constructing new ones at runtime. This allows Flutter to tree-shake unused icon fonts on web builds. The lookup maps will be auto-generated by the zeta-icons repo template going forward. Also replace non-constant IconData usage in the example app with ZetaIcon widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_copyWith()inIconExtensions.apply()with a lookup into consticonsRound/iconsSharpmaps, eliminating non-constantIconDataconstruction that broke--tree-shake-iconsiconsRoundandiconsSharpcodePoint lookup maps tozeta_icons(will be auto-generated by the zeta-icons template going forward)IconDatain example app withZetaIconwidgetzeta_icons1.9.2 → 1.9.3,zeta_flutter1.4.4 → 1.4.5Fixes the Flutter web release build error:
Depends on
Test plan
flutter build web --release --tree-shake-iconssucceedsflutter analyzepasses with no issues