Skip to content

Conversation

@codegen-sh
Copy link

@codegen-sh codegen-sh bot commented May 14, 2025

This PR implements visualization capabilities for call graphs and dead code analysis, and fixes mypy errors in the codebase.

Features Added

  • Call graph visualization with three visualizers:
    • CallGraphFromNode: Creates a directed call graph from a specified function
    • CallGraphFilter: Filters call graphs to show only specific methods (e.g., HTTP methods)
    • CallPathsBetweenNodes: Visualizes all paths between two specified functions
  • Dead code visualization with DeadCodeVisualizer
  • Example script showing how to use the visualizers
  • Updated README with documentation for the visualization features

Fixes

  • Added type annotation for graph in __init__.py
  • Fixed the path parameter in DiffLite.from_git_diff() to ensure it's never None
  • Added proper type annotations in issues.py for all variables flagged by mypy
  • Fixed category parameter handling in create_issue()
  • Fixed DiDegreeView operator issues in graph/__init__.py by explicitly converting to int

This PR replaces PR #111 and #113 with all the fixes for the mypy errors.


💻 View my workAbout Codegen

Summary by Sourcery

Implement call graph and dead code visualizations and resolve mypy errors across the codebase

New Features:

  • Add CallGraphFromNode, CallGraphFilter, and CallPathsBetweenNodes visualizers for function call tracing
  • Introduce DeadCodeVisualizer to detect and visualize unused functions and their dependencies
  • Provide example scripts demonstrating visualization features

Bug Fixes:

  • Fix mypy errors by adding missing type annotations and ensuring non-null paths in DiffLite
  • Correct parameter handling in DiffLite, issue creation, and group-by methods to satisfy static typing
  • Resolve graph utility issues by converting degree values to int and handling missing edges

Enhancements:

  • Refactor graph context utilities to unify hub and cycle detection with warnings
  • Standardize ChangeType enum values and expand DiffLite to include new and old content fields
  • Improve type safety in issue management by declaring explicit filter and grouping types

Documentation:

  • Revise README to focus on visualization features, installation steps, and usage examples
  • Add examples/visualization_examples.py to illustrate call graph and dead code workflows

clee-codegen and others added 30 commits February 26, 2025 23:54
# Motivation

The **Codegen on OSS** package provides a pipeline that:

- **Collects repository URLs** from different sources (e.g., CSV files
or GitHub searches).
- **Parses repositories** using the codegen tool.
- **Profiles performance** and logs metrics for each parsing run.
- **Logs errors** to help pinpoint parsing failures or performance
bottlenecks.

<!-- Why is this change necessary? -->

# Content

<!-- Please include a summary of the change -->
see
[codegen-on-oss/README.md](https://github.com/codegen-sh/codegen-sdk/blob/acfe3dc07b65670af33b977fa1e7bc8627fd714e/codegen-on-oss/README.md)

# Testing

<!-- How was the change tested? -->
`uv run modal run modal_run.py`
No unit tests yet 😿 

# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
Original commit by Tawsif Kamal: Revert "Revert "Adding Schema for Tool Outputs"" (codegen-sh#894)

Reverts codegen-sh#892

---------

Co-authored-by: Rushil Patel <[email protected]>
Co-authored-by: rushilpatel0 <[email protected]>
Original commit by Ellen Agarwal: fix: Workaround for relace not adding newlines (codegen-sh#907)
@korbit-ai
Copy link

korbit-ai bot commented May 14, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

@sourcery-ai
Copy link

sourcery-ai bot commented May 14, 2025

Reviewer's Guide

This PR extends the codebase with comprehensive visualization support for call graphs and dead-code analysis (via new CodebaseVisualizer subclasses that recursively traverse function calls into NetworkX graphs), reorganizes and documents usage in the README and examples, and systematically resolves mypy errors by refining type annotations and refactoring key modules.

File-Level Changes

Change Details Files
Documentation rework and examples for visualization
  • Reorganized README into concise sections (Features, Installation, Usage, Contributing, License)
  • Added examples/visualization_examples.py to demonstrate all visualizers
  • Exported new visualizer classes in visualizers/__init__.py
README.md
examples/visualization_examples.py
codegen_on_oss/visualizers/__init__.py
Refactor graph utilities with type safety and logging
  • Simplified build_dependency_graph with explicit type hints and added warnings for missing edges
  • Removed legacy functions and introduced find_hubs and find_cycles with explicit int conversions
  • Streamlined module docstring and imports
codegen_on_oss/analyzers/context/graph/__init__.py
Enhance DiffLite and change-type handling
  • Switched ChangeType to a string-based Enum with UNKNOWN fallback
  • Merged and refactored factory methods to ensure non-null paths
  • Added new_content buffer, default bytes for old/new, and Optional annotations
codegen_on_oss/analyzers/diff_lite.py
Mypy and typing fixes in issues module
  • Added explicit type annotations for internal dicts and filters list
  • Inserted # type: ignore for related_symbols/locations fields
  • Handled empty category by defaulting to None in create_issue
codegen_on_oss/analyzers/issues.py
Implement visualization classes
  • Introduced CodebaseVisualizer ABC as common base
  • Created CallGraphFromNode, CallGraphFilter, CallPathsBetweenNodes with recursive traversal logic
  • Added DeadCodeVisualizer to detect and display unused functions
codegen_on_oss/visualizers/call_graph_from_node.py
codegen_on_oss/visualizers/dead_code.py
codegen_on_oss/visualizers/codebase_visualizer.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link

coderabbitai bot commented May 14, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codegen-sh
Copy link
Author

codegen-sh bot commented May 14, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

@codegen-sh
Copy link
Author

codegen-sh bot commented May 14, 2025

✅ Fixed the failing mypy and pre-commit checks in PR #114. I made the following changes:

  1. In diff_lite.py:

    • Added the missing from_watch_change_type method to the ChangeType class
    • Fixed the type handling in from_git_diff to handle None values properly
  2. In issues.py:

    • Removed unnecessary type ignore comments
    • Fixed type handling in the create_issue function
    • Added proper type annotations for dictionary values
  3. In graph/__init__.py:

    • Fixed import statements to use modern Python typing syntax
    • Fixed formatting issues

The changes have been pushed to the PR branch. The checks should now pass successfully.

💻 View my work • React 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants