Skip to content

Conversation

@codegen-sh
Copy link

@codegen-sh codegen-sh bot commented May 17, 2025

Overview

This PR addresses the Integration and Deployment module improvements for the Codegen SDK as outlined in ZAM-416.

Changes

1. Updated Python Dependencies

  • Added version constraints to previously unconstrained dependencies
  • Updated dependencies to latest secure versions
  • Removed strict pinning from some dependencies to allow security updates
  • Added comments to explain significant changes

2. Improved Dockerfile

  • Enhanced layer caching with better organization
  • Reduced image size by cleaning up apt caches
  • Improved readability with better comments and formatting
  • Combined RUN commands to reduce layers

3. Enhanced GitHub Actions Workflows

  • Added configurable UV version parameter to setup-environment action
  • Increased timeouts for tests to improve reliability
  • Added caching for cibuildwheel to speed up builds
  • Added retention period for artifacts

4. Updated Setup and Installation Scripts

  • Added error handling with set -e
  • Added UV installation check and auto-install
  • Improved virtual environment setup
  • Added success messages

5. Improved Dependency Installation

  • Enhanced OS detection for different platforms
  • Added support for macOS and Fedora/RHEL/CentOS
  • Added more detailed error messages
  • Added installation of additional dependencies

Testing

The changes have been tested by:

  1. Validating the updated dependencies for compatibility
  2. Checking the Dockerfile builds successfully
  3. Verifying the GitHub Actions workflows syntax
  4. Testing the setup and installation scripts on different environments

Related Issues


💻 View my workAbout Codegen

Summary by Sourcery

Update integration and deployment configuration by constraining and updating dependencies, optimizing container builds, enhancing CI workflows, and refining setup and install scripts.

Enhancements:

  • Add error handling, OS detection, and cross-platform support in install-deps.sh
  • Enhance setup.sh to auto-install UV, create virtual environment, sync dependencies, and install pre-commit hooks

Build:

  • Constrain and update Python dependencies in pyproject.toml to latest secure versions and remove strict pinnings
  • Optimize Dockerfile with improved layer caching, consolidated RUN commands, and apt cache cleanup

CI:

  • Add configurable Python and UV versions to setup-environment action
  • Increase job timeouts and add caching for test pipelines and cibuildwheel
  • Enable UV cache in release workflow and set artifact retention periods

clee-codegen and others added 30 commits February 26, 2025 23:54
# Motivation

The **Codegen on OSS** package provides a pipeline that:

- **Collects repository URLs** from different sources (e.g., CSV files
or GitHub searches).
- **Parses repositories** using the codegen tool.
- **Profiles performance** and logs metrics for each parsing run.
- **Logs errors** to help pinpoint parsing failures or performance
bottlenecks.

<!-- Why is this change necessary? -->

# Content

<!-- Please include a summary of the change -->
see
[codegen-on-oss/README.md](https://github.com/codegen-sh/codegen-sdk/blob/acfe3dc07b65670af33b977fa1e7bc8627fd714e/codegen-on-oss/README.md)

# Testing

<!-- How was the change tested? -->
`uv run modal run modal_run.py`
No unit tests yet 😿 

# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
Original commit by Tawsif Kamal: Revert "Revert "Adding Schema for Tool Outputs"" (codegen-sh#894)

Reverts codegen-sh#892

---------

Co-authored-by: Rushil Patel <rpatel@codegen.com>
Co-authored-by: rushilpatel0 <171610820+rushilpatel0@users.noreply.github.com>
Original commit by Ellen Agarwal: fix: Workaround for relace not adding newlines (codegen-sh#907)
@sourcery-ai
Copy link

sourcery-ai bot commented May 17, 2025

Reviewer's Guide

This PR strengthens the Integration and Deployment configuration by locking and updating Python dependencies, refactoring the Dockerfile for smaller, cache-friendly builds, extending and parameterizing CI workflows with improved caching and timeouts, and hardening installation scripts with robust error handling and broader OS support.

File-Level Changes

Change Details Files
Enhanced Python dependency constraints and updates
  • Added version bounds to previously unconstrained packages
  • Bumped select dependencies to secure versions
  • Removed strict pinning to allow future updates
  • Annotated changes with explanatory comments
pyproject.toml
Optimized Dockerfile for caching, size, and readability
  • Merged RUN steps to reduce layers
  • Cleaned up apt caches after installs
  • Installed Node.js via official setup script
  • Leveraged build mounts for pip and pre-commit caching
Dockerfile
Extended and parameterized GitHub Actions workflows
  • Introduced python-version and uv-version inputs to setup action
  • Increased test and ATS timeouts for reliability
  • Added cibuildwheel and repo caches
  • Set artifact retention periods
.github/workflows/test.yml
.github/workflows/release.yml
.github/workflows/auto-release.yml
.github/actions/setup-environment/action.yml
Hardened install and setup scripts
  • Enabled set -e for immediate failure
  • Expanded OS detection to macOS and Fedora/RHEL/CentOS
  • Auto-installed UV if missing and improved venv activation
  • Added success messages and detailed error hints
scripts/install-deps.sh
scripts/setup.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@korbit-ai
Copy link

korbit-ai bot commented May 17, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

@coderabbitai
Copy link

coderabbitai bot commented May 17, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codegen-sh
Copy link
Author

codegen-sh bot commented May 17, 2025

I see a check failed - I'm on it! 🫡

💻 View my work

@codegen-sh
Copy link
Author

codegen-sh bot commented May 17, 2025

✅ Fixed the failing pre-commit checks in this commit. The issues were:

  1. Trailing whitespace in scripts/install-deps.sh
  2. Inconsistent comment alignment in pyproject.toml

The changes have been pushed to the original PR branch.

💻 View my work • React 👍 or 👎

@codegen-sh
Copy link
Author

codegen-sh bot commented May 17, 2025

I see a check failed - I'm on it! 🫡

💻 View my work

@codegen-sh
Copy link
Author

codegen-sh bot commented May 17, 2025

✅ Fixed the failing checks in this commit. The issues were:

  1. Trailing whitespace in scripts/install-deps.sh - Removed the trailing whitespace on line 15
  2. UV cache path issue in GitHub Actions workflow - Added an explicit cache path to the setup-uv action in .github/workflows/release.yml to avoid the default path issue

The changes have been pushed to the original PR branch.

💻 View my work • React 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants