feat: add max_battery_output_power sensor to ZendureManager#1141
Open
eremid wants to merge 1 commit intoZendure:masterfrom
Open
feat: add max_battery_output_power sensor to ZendureManager#1141eremid wants to merge 1 commit intoZendure:masterfrom
eremid wants to merge 1 commit intoZendure:masterfrom
Conversation
Introduces a new sensor that calculates the cumulative maximum output power from batteries across all fuse groups. The value is determined by summing the hardware discharge limits of all battery-equipped devices (kWh > 0) within each fuse group, constrained by the group's maximum power capacity. - Added 'max_battery_output_power' entity to ZendureManager. - Implemented calculation logic with fuse group capping and battery filtering. - Ensured the sensor updates when fuse groups change or during the main manager update. - Included translations for en, de, fr, and nl.
Collaborator
|
Hi @eremid I understand the idea, but I am a bit hesitant to add too many entities, since it becomes more difficult for new users to understand. It is clear you cannot access these values yourself. The place where you added the update is called very often, which to keep everything as smooth as possible is not ideal. In another PR I added something similar, the totalKwh. Let me think about fixing them together! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
max_battery_output_powersensor to the Zendure integration.Need
The purpose of this sensor is to provide the actual total discharge capacity of the setup, considering both hardware limits and fuse group constraints. This allows users to:
Key Changes
max_battery_output_powertoZendureManager.kWh > 0).maxpowerconfiguration.