make time_t format string work for all types of time_t #366
Merged
ZerBea merged 1 commit intoZerBea:masterfrom Feb 3, 2026
Merged
make time_t format string work for all types of time_t #366ZerBea merged 1 commit intoZerBea:masterfrom
ZerBea merged 1 commit intoZerBea:masterfrom
Conversation
Owner
|
Good point. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not every OS has time_t defined as long. As for example OpenBSD uses long long.
Therefore there are ugly warnings I see when building hcxpcapngtool on OpenBSD
about the format string.
To fix it, use %jd and cast the variable to intmax_t.
This should be standardized and available since C99.