Conversation
…push events github.base_ref is empty on push events, causing the job to run without a GitHub environment. Use the same fallback pattern as terraform_workspace: base_ref || ref_name.
Contributor
Qlebrun
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the default value of
environment_namein thefetch-terraform-outputworkflow.Why
github.base_refis empty on push events (it's only set on pull requests), so the job was running without a GitHub environment — meaningAWS_ACCOUNT_IDandAWS_REGIONvars were never loaded, causing the S3 state fetch to fail.Changes
environment_namedefault:${{ github.base_ref }}→${{ github.base_ref || github.ref_name }}Same fallback pattern already used by
terraform_workspacein this same workflow.Testing
Callers that explicitly pass
environment_nameare unaffected. Callers that rely on the default (push events) will now get the correct environment.