Core: Use a consistent implementation for arrays #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for awaitable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ZeroIntensity
changed the title
ZeroIntensity
added a commit
that referenced
this pull request
Jan 8, 2025
Apparently, #48 broke some builds. - Fixes compiler flags used on Windows. - Removes usage of `Py_UNREACHABLE`, which apparently only works on Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly importantly, this removes any size limits and significantly reduces the size of a PyAwaitable object.
A couple other things as well:
PYAWAITABLE_OPTIMIZEDsetting for CI.SystemErrortoRuntimeError, because apparently it wasn't clear that those were user errors.