Moved all internal headers to a single internal header. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for awaitable canceled.
|
ZeroIntensity
previously requested changes
Jan 8, 2025
Owner
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
This is going to be a mess--there should be a _pyawaitable.h that includes all of the subfiles, not move them all to one file. The vendor script can do that at build time.
AraHaan
force-pushed
the
use-single-internal-header
branch
from
85886e7 to
ddf7440
Compare
This should help make it easier to vendor later.
AraHaan
force-pushed
the
use-single-internal-header
branch
from
ddf7440 to
189e09f
Compare
AraHaan
commented
Jan 8, 2025
| a.py | ||
| vgcore* | ||
|
|
||
| # Other Visual Studio stuff. |
Collaborator
Author
There was a problem hiding this comment.
I use a local only Visual Studio project folder and don't want to accidentally commit those files so I ignored them here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help make it easier to vendor later. Also in this change the contents of coro.c has been moved into awaitable.c.
Since this is not a breaking change it can go into v1.4.0, but we need to consider releases after v1.4.0 to become a part of v2 pyawaitable.