Skip to content

Add PyAwaitable_DeferAwait #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AraHaan merged 14 commits into from
Jan 9, 2025
Merged

Add PyAwaitable_DeferAwait #52

AraHaan merged 14 commits into from
Jan 9, 2025

Conversation

@AraHaan
Copy link
Collaborator

@AraHaan AraHaan commented Jan 9, 2025

Implements #36.

@AraHaan AraHaan added the feature New feature or request label Jan 9, 2025
@AraHaan AraHaan requested a review from ZeroIntensity January 9, 2025 16:11
@netlify
Copy link

netlify bot commented Jan 9, 2025 •
edited
Loading

✅ Deploy Preview for awaitable canceled.

Name Link
🔨 Latest commit 561b49c
🔍 Latest deploy log https://app.netlify.com/sites/awaitable/deploys/678023e69f74d90008c192b3

ZeroIntensity
ZeroIntensity reviewed Jan 9, 2025
View reviewed changes
Copy link
Owner

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

ZeroIntensity
ZeroIntensity reviewed Jan 9, 2025
View reviewed changes
Copy link
Owner

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also update the ctypes bindings in src/pyawaitable/bindings.py and add tests with them.

@AraHaan AraHaan added this to the 1.4.0 milestone Jan 9, 2025
@AraHaan
Copy link
Collaborator Author

AraHaan commented Jan 9, 2025

I wonder if the test should start out as sync and simply use asyncio.run to test the defined awaitable in the test code.

@ZeroIntensity
Copy link
Owner

ZeroIntensity commented Jan 9, 2025

Why? pytest.mark.asyncio works fine. (And, I'm not sure if asyncio.run supports non-native coroutines.)

ZeroIntensity
ZeroIntensity reviewed Jan 9, 2025
View reviewed changes
Copy link
Owner

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll deal with documentation after this gets merged.

@AraHaan AraHaan force-pushed the add-defer-callback branch from bafb6f6 to 561b49c Compare January 9, 2025 19:30
@AraHaan AraHaan linked an issue Jan 9, 2025 that may be closed by this pull request
Add a special type of awaitable callback that defers calling a python coroutine until the awaitable object is awaited. #36
Closed
@ZeroIntensity ZeroIntensity changed the title Add defer await callback feature. Add PyAwaitable_DeferAwait Jan 9, 2025
@AraHaan AraHaan merged commit 4c5303f into master Jan 9, 2025
26 checks passed
@AraHaan AraHaan deleted the add-defer-callback branch January 9, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

feature New feature or request

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

Add a special type of awaitable callback that defers calling a python coroutine until the awaitable object is awaited.

3 participants

@AraHaan @ZeroIntensity