-
-
Notifications
You must be signed in to change notification settings - Fork 3
Use vendoring as the distribution method #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added that generated header to .gitignore.
This is because the older versions are not supported, and also have reached End of Life.
This will be available as a separate include inside of a separate github repository soon. If anyone still needs it they can clone that repository and add it to their include paths.
This will make Visual Studio output less errors when it goes to do it's error checking thing before any builds are performed.
…a weak reference to the module the pyawaitable types get added to. This module object is then in turn internal to the C extension itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates function tables entirely, and instead ships the entire PyAwaitable source code as a header file. This may seem bad at first, but has a lot of nice benefits for us:
On the other hand, there a few downsides:
ctypesbindings need to be written in favor of a C extension.Closes #30 and #47.