Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions data/static/codefixes/loginAdminChallenge_3.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import {BasketModel} from "../../../models/basket";
import {BasketModel}from "../../../models/basket";
const MAX_FAILED_ATTEMPTS = 5
const LOCK_TIME = 15 * 60 * 1000 // 15 minutes
const loginFailures: Record<string, { count: number, firstFailureTime: number }> = {}

module.exports = function login () {
function afterLogin (user: { data: User, bid: number }, res: Response, next: NextFunction) {
Expand All @@ -14,6 +17,14 @@ module.exports = function login () {
}

return (req: Request, res: Response, next: NextFunction) => {
const email = req.body.email
const failure = loginFailures[email]
if (failure && failure.count >= MAX_FAILED_ATTEMPTS && Date.now() - failure.firstFailureTime < LOCK_TIME) {
return res.status(429).send(res.__('Too many login attempts. Please try again later.'))
}
if (failure && Date.now() - failure.firstFailureTime >= LOCK_TIME) {
delete loginFailures[email]
}
models.sequelize.query(`SELECT * FROM Users WHERE email = $1 AND password = $2 AND deletedAt IS NULL`,
{ bind: [ req.body.email, req.body.password ], model: models.User, plain: true })
.then((authenticatedUser) => {
Expand All @@ -31,9 +42,18 @@ module.exports = function login () {
} else if (user.data?.id) {
afterLogin(user, res, next)
} else {
const now = Date.now()
if (!loginFailures[email] || now - loginFailures[email].firstFailureTime >= LOCK_TIME) {
loginFailures[email] = { count: 1, firstFailureTime: now }
} else {
loginFailures[email].count += 1
}
if (loginFailures[email].count >= MAX_FAILED_ATTEMPTS) {
return res.status(429).send(res.__('Too many login attempts. Please try again later.'))
}
res.status(401).send(res.__('Invalid email or password.'))
}
}).catch((error: Error) => {
next(error)
})
}
}