fix(graph): make graph format explicit#146
Draft
schmidma wants to merge 2 commits intoZettaScaleLabs:mainfrom
Draft
fix(graph): make graph format explicit#146schmidma wants to merge 2 commits intoZettaScaleLabs:mainfrom
schmidma wants to merge 2 commits intoZettaScaleLabs:mainfrom
Conversation
b847824 to
9905f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub shows this PR against
main, but the intended review base is #161.Make graph backend selection explicit by changing
Graph::newto require aKeyExprFormat, and alignZContextBuilderso the context-owned graph uses the same format selected via.keyexpr_format(...).This fixes an inconsistency where nodes, publishers, subscribers, and services respected the context format, but the internal graph always used the default
RmwZenohparser and pattern.It also restores correct behavior for graph-backed helpers under
Ros2Dds, including publisher and subscriber matching via the context-owned graph.Checklist
./scripts/check-local.shsuccessfully