Skip to content

Conversation

@kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jan 23, 2026

Description

  • Add ability to discover mints filtered by ZEUS' Nostr follows, all users, or custom npub
  • Display mint reviews with user profiles, star ratings, and expandable content
  • Submit mint reviews to Nostr relays (anonymous or with user's nsec)

In a future PR, we'll add Nostr key and relay management under Settings

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Test plan

  • Open Add Mint view, tap "Discover mints"
  • Test all 3 discovery modes (ZEUS follows, All users, Custom npub)
  • Tap "View reviews" on a mint recommendation
  • Verify long reviews show "Tap to expand"
  • Open a mint detail view, tap "Submit review"
  • Submit a review with rating and text (anonymous)
  • Submit a review using nsec

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kaloudis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Cashu mint management experience by integrating a robust review system powered by Nostr. It allows users to make more informed decisions when adding new mints by providing access to community-driven recommendations and reviews. The new features streamline mint discovery and foster a more transparent ecosystem for Cashu mints within the application.

Highlights

  • Nostr-Integrated Mint Review System: Introduced a comprehensive system for discovering, viewing, and submitting reviews for Cashu mints, leveraging Nostr (NIP-87) for decentralized review data.
  • Flexible Mint Discovery: Users can now discover mints based on recommendations from ZEUS's Nostr follows, all Nostr users, or a custom Nostr public key (npub) follow list.
  • Rich Review Display: Mint reviews are displayed with user profiles (including name and picture if available), star ratings, and expandable content for longer reviews.
  • Secure Review Submission: Users can submit mint reviews to Nostr relays, choosing between anonymous submission (generating a new Nostr identity) or signing with their existing Nostr private key (nsec).
  • Nostr Utility Functions: Added a new NostrUtils class with helper functions for validating, encoding, and decoding Nostr public and private keys (npub/nsec) to/from hex format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive mint review system integrated with Nostr, a significant and well-executed feature. It adds the ability to discover mints through various Nostr-based filters, view detailed reviews with user profiles and ratings, and submit new reviews. The implementation is solid, with new logic in CashuStore, extensive UI changes in AddMint.tsx and Mint.tsx, and a robust NostrUtils module with thorough testing. My feedback focuses on a couple of opportunities to improve code quality and maintainability by refactoring duplicated code and ensuring data consistency.

Copy link
Contributor

@ajaysehwal ajaysehwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screenshot - iPhone 17 Pro - 2026-01-27 at 16 31 05

@kaloudis, I think the error message isn’t very clear. Could we make the input value red when the npub format is invalid?

Copy link
Contributor

@ajaysehwal ajaysehwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screenshot - iPhone 17 Pro - 2026-01-27 at 16 54 39

npub input doesn’t look properly aligned. Is that expected?

Copy link
Contributor

@ajaysehwal ajaysehwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screenshot - iPhone 17 Pro - 2026-01-27 at 17 01 07

I think we should hide the vertical scroll indicator here as well ?

@kaloudis kaloudis requested a review from ajaysehwal January 29, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants