refactor: deduplicate invoice option calculations in Receive view

[kaloudis]

Description

Before: The values were calculated twice:

• Lines 302-318: Inline within setState
• Lines 361-375: As separate constants before autoGenerateInvoice

After: Values are calculated once at lines 294-308 and reused:

• routeHints, ampInvoice, blindedPaths are now constants defined before setState
• The same constants are passed to both setState (lines 318-320) and autoGenerateInvoice (lines 435-437)
• newExpirySeconds (already existed at line 274) is now consistently used in both places

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (CLNRest)
• Nostr Wallet Connect
• LndHub

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[gemini-code-assist]

Summary of Changes

Hello @kaloudis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Receive view to improve code efficiency and maintainability by eliminating duplicate calculations for invoice generation options. By consolidating these computations into a single block and reusing the results, the change reduces redundant processing and makes the code easier to understand and manage.

Highlights

• Consolidated Invoice Option Calculations: The calculations for routeHints, ampInvoice, and blindedPaths have been moved to a single location (lines 294-308) to prevent redundant computations.
• Refactored setState Usage: The setState method now utilizes the newly defined constants for invoice options, eliminating their inline recalculation.
• Removed Duplicate Calculations: Redundant calculations for expirySeconds, routeHints, ampInvoice, and blindedPaths have been removed from the logic preceding the autoGenerateInvoice call.
• Consistent Expiry Seconds Usage: The autoGenerateInvoice function now consistently uses newExpirySeconds, which was already defined earlier, ensuring uniformity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the Receive view to deduplicate the calculation of invoice options. By calculating routeHints, ampInvoice, and blindedPaths once in componentDidMount and reusing these constants, the code is now cleaner, more maintainable, and less prone to errors from inconsistent logic. The consistent use of newExpirySeconds is also a good fix. I have a couple of minor suggestions to use a more idiomatic approach for boolean conversions, but overall, this is a solid improvement.