-
-
Notifications
You must be signed in to change notification settings - Fork 219
feat: Android: Stealth Mode #3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kaloudis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Android application's capabilities by introducing a privacy-focused 'Stealth Mode' and overhauling core wallet functionalities. It modernizes the user interface with Jetpack Compose for key interactions and strengthens network and API integrations, particularly for advanced transaction types and privacy features. The changes aim to deliver a more robust, private, and user-friendly experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a 'Stealth Mode' feature for Android, which allows users to change the app's icon and name for privacy. The implementation is solid, using Android's activity-alias and a native module to manage the different app appearances. The code includes a crucial safety mechanism to prevent the app from becoming inaccessible.
My review focuses on the files related to the Stealth Mode feature. I've noticed a large number of files under the ashigaru-mobile/ directory have been added. This seems to be a separate project and likely included by mistake. Please consider removing this directory from the pull request.
I have one suggestion for improving the maintainability of the StealthMode.java native module.
d016b23 to
f2ab374
Compare
Description
Relates to issue: ZEUS-506
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: