Skip to content

Conversation

@kaloudis
Copy link
Contributor

Description

Relates to issue: ZEUS-506

Screenshot_1769321594

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added Android Android issues Privacy labels Jan 25, 2026
@kaloudis kaloudis linked an issue Jan 25, 2026 that may be closed by this pull request
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kaloudis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Android application's capabilities by introducing a privacy-focused 'Stealth Mode' and overhauling core wallet functionalities. It modernizes the user interface with Jetpack Compose for key interactions and strengthens network and API integrations, particularly for advanced transaction types and privacy features. The changes aim to deliver a more robust, private, and user-friendly experience.

Highlights

  • Stealth Mode Implementation: Introduced a new 'Stealth Mode' feature for Android, allowing the app's launcher icon to be disguised as common utility apps like a calculator, VPN, QR scanner, or notepad. This is achieved through dynamic activity-alias management in the AndroidManifest.xml and a dedicated StealthMode.java module.
  • Wallet Management & Transaction Enhancements: Added extensive new functionalities for wallet creation/restoration (from mnemonic or backup), handling various transaction types including Cahoots (manual and online via Soroban) and PSBT, and managing UTXOs. This includes new activities for creating/restoring wallets, displaying transaction animations, and manual transaction broadcasting.
  • UI Modernization with Jetpack Compose: Integrated Jetpack Compose for several new UI components, including account selection, Cahoots transaction setup, and Paynym selection, providing a more modern and responsive user experience.
  • Network & API Integration: Enhanced network interaction with dedicated HTTP clients for Whirlpool and PayNym, improved Tor integration, and new API clients for fetching fees, seen addresses, transactions, and xpub tracking. This also includes a mechanism for checking and updating app-related URLs via PGP-signed messages.
  • Developer & Maintenance Tools: Added an exception report handler for crash logging, a web explorer with Tor proxy support, and utilities for managing BIP39 wordlists and device footprints, improving app stability and debuggability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kaloudis kaloudis added this to the v0.13.0 milestone Jan 25, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 'Stealth Mode' feature for Android, which allows users to change the app's icon and name for privacy. The implementation is solid, using Android's activity-alias and a native module to manage the different app appearances. The code includes a crucial safety mechanism to prevent the app from becoming inaccessible.

My review focuses on the files related to the Stealth Mode feature. I've noticed a large number of files under the ashigaru-mobile/ directory have been added. This seems to be a separate project and likely included by mistake. Please consider removing this directory from the pull request.

I have one suggestion for improving the maintainability of the StealthMode.java native module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Android issues Privacy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add private app icon feature

1 participant