Export Activity to CSV: rephrasing for clarity

[myxmaster]

Description

Relates to #3497 (comment)

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (CLNRest)
• Nostr Wallet Connect
• LndHub

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[gemini-code-assist]

Summary of Changes

Hello @myxmaster, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity of the user interface by updating the text for activity export options. The changes specifically refine the English labels for exporting Lightning Payments, Lightning Invoices, and On-chain Transactions, ensuring users have a more precise understanding of what each export option entails.

Highlights

• UI Text Clarity: The labels for activity export options have been rephrased in the English locale file to provide more specific descriptions for different transaction types.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the locale strings for the activity export feature to improve clarity by specifying "Lightning" and "On-chain" for different export types. This is a good improvement. However, I've noticed a small discrepancy where the labels for exporting payments and invoices are specified as "Lightning", but the functionality also exports Cashu-related activities. I've left a couple of suggestions to make the labels more accurate and avoid potential user confusion.

[gemini-code-assist]

The new label "Export Lightning Payments" is more specific, but it's not entirely accurate. The underlying functionality in views/Tools/ActivityExport.tsx exports both Lightning payments (Payment) and Cashu payments (CashuPayment). This could be misleading for users. To accurately reflect what is being exported, consider changing the label to "Export Lightning & Cashu Payments".

Suggested change

	"views.ActivityExport.exportPayments": "Export Lightning Payments",
	"views.ActivityExport.exportPayments": "Export Lightning & Cashu Payments",

[gemini-code-assist]

Similar to the payments export, the label "Export Lightning Invoices" is not fully accurate. The export includes both Lightning invoices (Invoice) and Cashu invoices (CashuInvoice). To avoid confusion, I suggest updating the label to "Export Lightning & Cashu Invoices".

Suggested change

	"views.ActivityExport.exportInvoices": "Export Lightning Invoices",
	"views.ActivityExport.exportInvoices": "Export Lightning & Cashu Invoices",

[myxmaster]

Ok, I wasn't aware / thinking about that.

I guess the easiest solution is indeed to call it "Export Lightning & Cashu Invoices" and "Export Lightning & Cashu Payments" then?