fix: Add share icon for BBQr codes and remove speed control

[ajaysehwal]

Description

Please enter a description and screenshots, if appropriate, of the work covered in this PR

Before	After

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (CLNRest)
• Nostr Wallet Connect
• LndHub

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[gemini-code-assist]

Summary of Changes

Hello @ajaysehwal, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the user interface and functionality related to Cashu token management. It introduces broader availability for the share feature, particularly for 'BBQr codes,' and refines the display logic for speed controls, streamlining the user experience by removing unnecessary options in certain contexts. The changes aim to make interaction with Cashu tokens more intuitive and efficient.

Highlights

• Share Icon Availability: The share icon for Cashu tokens is now displayed in more scenarios, specifically for 'BBQr codes' when the token is not too large (corresponding to selectedIndex 0 or 2) and also when the token is too large (corresponding to selectedIndex 1). This expands the ability to share these tokens.
• Speed Control Logic Adjustment: The conditional logic for displaying the 'speed control' has been refined. It is now shown only when the token is not too large and selectedIndex is 1, or when the token is too large and selectedIndex is 0. This change effectively removes the speed control from certain views where it was previously present.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the UI for displaying Cashu tokens by adding a share icon for BBQr codes and removing the speed control for them, while keeping it for BC-ur codes. The implementation correctly adjusts the visibility of the share and speed control icons based on the selected QR code type and token size.

My review includes a suggestion to refactor the conditional logic for showing these icons. While functionally correct, the current implementation is complex and could be made more readable and maintainable by using descriptive variables, which would make the code more robust for future changes.

[kaloudis]

LGTM