Skip to content

Conversation

@kaloudis
Copy link
Contributor

Description

Re-implementation of all of our Cashu ecash functionality, using CDK

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.13.0 milestone Jan 27, 2026
@kaloudis kaloudis added Dependencies Pull requests that update a dependency file Ecash Cashu CDK labels Jan 27, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kaloudis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a major refactoring of the ecash functionality in the Zeus wallet by integrating the Cashu Development Kit (CDK). This change replaces the existing cashu-ts library with a more robust and efficient native implementation, enhancing the wallet's performance and reliability. The PR includes the necessary native modules for both Android and iOS, along with significant code refactoring to accommodate the new architecture.

Highlights

  • CDK Integration: This PR integrates the Cashu Development Kit (CDK) to replace the existing cashu-ts library. This brings improved performance and reliability for ecash functionality.
  • Native Module Implementation: A new React Native native module (CashuDevKitModule) is added for both Android (Kotlin) and iOS (Swift), providing a bridge to the CDK FFI bindings.
  • Code Modernization: The codebase is refactored to use async/await for asynchronous operations, improving code readability and maintainability.
  • Dependency Updates: The PR updates build configurations, dependencies, and library fetching scripts to include the CDK and its dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link
Contributor

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.

Copy link
Contributor

@ajaysehwal ajaysehwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaloudis, I think Cashu token locking isn’t working. In this screen recording, I locked the token to another Cashu wallet, but I’m still able to redeem it.

Screen.Recording.2026-01-28.at.12.59.29.PM.mov

Copy link
Contributor

@ajaysehwal ajaysehwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2026-01-28.at.1.14.14.PM.mov

@ajaysehwal
Copy link
Contributor

@kaloudis, I think Cashu token locking isn’t working. In this screen recording, I locked the token to another Cashu wallet, but I’m still able to redeem it.

Screen.Recording.2026-01-28.at.12.59.29.PM.mov

fixed in #3616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cashu CDK Dependencies Pull requests that update a dependency file Ecash

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants