Skip to content

Conversation

@kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jan 27, 2026

Description

This PR is two-fold:

  1. It adds the ability to parse links from ZEUS' new Cashu gift portal, when users errantly enters it into ZEUS, instead of the Cashu token directly.

eg: https://zeusln.com/e/cashuAeyJ0b2tlbiI6IFt7InByb29mcyI6IFtdLCAibWludCI6ICJodHRwczovL21pbnQuZXhhbXBsZS5jb20ifV19

  1. It adds a Gift link option on the share modal, when the user hits the share icon on the Cashu token view. The https://zeusln.com/e/ endpoint is simply prefixed to the token string here.
Gift link option in ZEUS Gift web portal
Simulator Screenshot - iPhone 17 Pro - 2026-01-27 at 19 38 27 Simulator Screenshot - iPhone 17 Pro - 2026-01-27 at 19 38 49

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kaloudis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant new feature by enabling the application to correctly parse and handle ZEUS Cashu gift links. This enhancement allows users to interact with Cashu tokens distributed via a specific URL scheme, expanding the types of inputs the application can interpret and process for payment or data handling.

Highlights

  • Cashu Gift Link Handling: Implemented new logic within the handleAnything utility to recognize and process ZEUS Cashu gift links, which are URLs starting with https://zeusln.com/e/.
  • Cashu Token Extraction and Validation: The system now extracts Cashu tokens embedded in these gift links, validates them using CashuUtils.isValidCashuToken, and decodes them into a CashuToken object.
  • Comprehensive Unit Testing: Added a dedicated test suite for zeusln.com/e/ URLs in handleAnything.test.ts, covering various scenarios including valid/invalid tokens, clipboard interactions, URL formatting, and edge cases like incorrect paths or protocols.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for ZEUS Cashu gift links by adding new logic to handleAnything.ts and corresponding unit tests in handleAnything.test.ts. The changes correctly identify and process https://zeusln.com/e/ URLs containing Cashu tokens, including validation and decoding. The test coverage for this new feature is comprehensive, covering various valid and invalid scenarios, as well as clipboard interactions.

@kaloudis kaloudis marked this pull request as ready for review January 27, 2026 23:19
@kaloudis kaloudis marked this pull request as draft January 28, 2026 00:55
@kaloudis kaloudis force-pushed the zeus-cashu-gift-links branch from e00656d to a42d60e Compare January 28, 2026 01:12
@kaloudis kaloudis changed the title feat: handle ZEUS Cashu gift links feat: ZEUS Cashu gift portal links Jan 28, 2026
@kaloudis kaloudis marked this pull request as ready for review January 28, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant