feat: Add modal explainer for pending payment clock icon (#3601)

[a-khushal]

Description

Relates to issue: ZEUS-3601

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (CLNRest)
• Nostr Wallet Connect
• LndHub

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[gemini-code-assist]

Summary of Changes

Hello @a-khushal, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature aimed at improving user clarity within the Nostr Wallet Connect (NWC) settings. It implements an interactive modal that provides a detailed explanation for the 'pending payment clock icon,' helping users understand its significance. The modal also offers a convenient shortcut to view and manage these pending payment requests, enhancing the overall user experience and accessibility of NWC functionalities.

Highlights

• Pending Payment Explainer Modal: A new informational modal has been introduced, triggered by tapping the clock icon in the Nostr Wallet Connect (NWC) connections list. This modal clarifies the meaning of the icon, explaining that it indicates pending payment requests from NWC connections that have not yet been processed.
• Direct Navigation to Pending Payments: The newly added modal includes a button that allows users to directly navigate to the 'NWCPendingPayments' screen, providing quick access to manage these requests.
• Localization Updates: New locale strings have been added in 'en.json' for the modal's title, explainer text, button label, and accessibility label, ensuring the feature is ready for internationalization. A new, shorter title for the NWC service was also added.
• UI Text Refinement: The header title for the NWC connections list has been updated to use a shorter, more concise 'NWC service' label.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an explainer modal for the pending payments icon, which is a nice user experience improvement. The implementation correctly leverages the existing ModalStore to display this information. My review has identified a couple of hardcoded true values in conditional rendering logic, likely left over from development. These should be replaced with dynamic variables to ensure the UI behaves as expected.

[gemini-code-assist]

The condition for selecting the shorter header title is hardcoded to true. This should be replaced with the shouldReduceIconSize variable to dynamically adjust the title based on the number of icons displayed in the header.

Suggested change

	true
	? 'views.Settings.NWC.title'
	: 'views.Settings.NostrWalletConnect.title'
	shouldReduceIconSize
	? 'views.Settings.NWC.title'
	: 'views.Settings.NostrWalletConnect.title'

[gemini-code-assist]

The condition for displaying the pending payments clock icon is hardcoded to true. This should be changed back to hasPendingPayments to ensure the icon is only shown when there are pending payments.

Suggested change

	{true && (
	{hasPendingPayments && (

[kaloudis]

This is not what I had in mind.

We just wanted to add a modal for the clock icon on the balance pane