Skip to content

ICC-Deathwhisper: do not warn to interrupt frostbolt when on cooldown#224

Open
dsp28 wants to merge 1 commit intoZidras:mainfrom
dsp28:icc-deathwhisper-interrupt-filter
Open

ICC-Deathwhisper: do not warn to interrupt frostbolt when on cooldown#224
dsp28 wants to merge 1 commit intoZidras:mainfrom
dsp28:icc-deathwhisper-interrupt-filter

Conversation

@dsp28
Copy link

@dsp28 dsp28 commented Nov 11, 2024

When playing ICC-Deathwhisper, DBM distracts me by constantly screaming at me to interrupt frostbolt cast even if my interrupt ability is on cooldown. This fix skips interrupt warning if the interrupt ability is on cooldown!

@broizter
Copy link
Contributor

I feel like that is not a great design decision. Imagine a situation where the frostbolt cast starts when you have 0.1 seconds left on your CD. You could still interrupt the cast but DBM wouldn't send you an alert about it.

@dsp28
Copy link
Author

dsp28 commented Dec 18, 2024

Thanks for your comment @broizter. You are correct, in that edge case the warning will not fire even though the player can interrupt the boss.
Personally I am willing to make that trade-off. I would rather not be distracted while my interrupt ability is on cooldown. If this edge case happens: someone else in raid with interrupt ability off cooldown will get the warning and interrupt, then I can get back into it on the next boss frostbolt cast!

@Zidras
Copy link
Owner

Zidras commented Dec 19, 2024

Apologies for letting this one pass @dsp28 , I usually revert to the PR'er sooner. While I agree with @broizter 's opinion, I see value in your suggestion.
If I am understanding correctly, the interrupt filtering should account not only for ability on cooldown (dsp28 PR), but also whether or not current casttime of ability to interrupt would end sooner than your interrupter (joint idea from both).

I would have to check the underlying code to see whether or not checking for the ability cooldown is feasible with not too much code effort (no estimate on when I can tackle this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments