ICC-Deathwhisper: do not warn to interrupt frostbolt when on cooldown#224
ICC-Deathwhisper: do not warn to interrupt frostbolt when on cooldown#224dsp28 wants to merge 1 commit intoZidras:mainfrom
Conversation
|
I feel like that is not a great design decision. Imagine a situation where the frostbolt cast starts when you have 0.1 seconds left on your CD. You could still interrupt the cast but DBM wouldn't send you an alert about it. |
|
Thanks for your comment @broizter. You are correct, in that edge case the warning will not fire even though the player can interrupt the boss. |
|
Apologies for letting this one pass @dsp28 , I usually revert to the PR'er sooner. While I agree with @broizter 's opinion, I see value in your suggestion. I would have to check the underlying code to see whether or not checking for the ability cooldown is feasible with not too much code effort (no estimate on when I can tackle this) |
When playing ICC-Deathwhisper, DBM distracts me by constantly screaming at me to interrupt frostbolt cast even if my interrupt ability is on cooldown. This fix skips interrupt warning if the interrupt ability is on cooldown!