#449 add explicit to node constructor#484
Merged
ZigRazor merged 3 commits intoZigRazor:masterfrom Feb 3, 2025
Merged
Conversation
ZigRazor
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #449 by adding explicit keyword to constructor
In an ideal scenario I would write a fails to compile test. I looked for a nice way to do it with SNIAFE but it's been flaky with me in the past and I've forgotten how to.
I have considered adding
try_compileto the CMake, something like:where CompileTests.cpp.in contains something like:
I thought GDAL did something similar but I had a look at the source code and can't see it so I assume I've confused it with something (I had a look at geos too but nothing obvious).