Skip to content

Conversation

@vil02
Copy link
Contributor

@vil02 vil02 commented Oct 29, 2025

This change consists of two parts:

  • use std::any_of and std::none_of in isDirectedGraph() and isUndirectedGraph() respectively,
  • simplify the logic of using std::optional<bool> by mostly using .value_or().

I decided not to update the test files. My plan is to do in in another PR, so it will be easier to see that these changes do not change the logic.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.07%. Comparing base (e968842) to head (37779f6).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
include/CXXGraph/Graph/Algorithm/Dijkstra_impl.hpp 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   97.08%   97.07%   -0.01%     
==========================================
  Files          98       98              
  Lines       11355    11333      -22     
  Branches      799      796       -3     
==========================================
- Hits        11024    11002      -22     
  Misses        331      331              
Flag Coverage Δ
unittests 97.07% <92.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 marked this pull request as ready for review October 29, 2025 16:41
@ZigRazor ZigRazor merged commit fb8de4e into ZigRazor:master Oct 30, 2025
17 of 20 checks passed
@vil02 vil02 deleted the simplify_usage_of_optional_bool branch October 30, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants