Skip to content

Conversation

@vil02
Copy link
Contributor

@vil02 vil02 commented Oct 31, 2025

After #553, CodeQL is failing.

This is an attempt to fix it.

It turned out that linking pthread, ssl, crypto and z is no loner needed, so I removed it.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (d5549b2) to head (32bd1ea).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   97.06%   97.07%           
=======================================
  Files          98       98           
  Lines       11291    11291           
  Branches      796      796           
=======================================
+ Hits        10960    10961    +1     
+ Misses        331      330    -1     
Flag Coverage Δ
unittests 97.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 marked this pull request as ready for review October 31, 2025 17:02
This change additionally removes unnecessary linked libraries.
@ZigRazor ZigRazor merged commit 200d838 into ZigRazor:master Nov 3, 2025
20 checks passed
@vil02 vil02 deleted the fix_code_ql branch November 5, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants