Modify tests for torch result comparison #12
+389
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tests/test-flash-attn-state.cppfile was significantly updated to include PyTorch result comparison and enhanced validation.Key changes include:
%23ifdef LLAMA_TORCH_AVAILABLE) for PyTorch-dependent code.ggml_to_torchfunction for convertingggml_tensortotorch::Tensor, handling type conversion (F16 to F32) and dimension reshaping.torch::scaled_dot_product_attentionfor PyTorch's flash attention computation.ggml's mask.42for reproducible test results.Standard,Segmented, andPyTorchresults.StandardandSegmentedflash attention results showed a0.000000e 00maximum difference, confirming thewith_stateoperator's correctness and numerical stability.ggml's results and PyTorch'sscaled_dot_product_attention(max diff:7.57e-01), likely due to differing numerical algorithms or precision handling in PyTorch.