ZBUG-5250: Modern UI, contact cannot be saved when more than two same type addresses exist#798
Open
sumitTelus wants to merge 1 commit intomasterfrom
Open
ZBUG-5250: Modern UI, contact cannot be saved when more than two same type addresses exist#798sumitTelus wants to merge 1 commit intomasterfrom
sumitTelus wants to merge 1 commit intomasterfrom
Conversation
- Change contact schema to use arrays for multi-value fields - Add ContactAttributeChange type for modify operations - Update normalization logic to convert between SOAP and GraphQL formats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Modern UI not allowing to create a contact with more than two email addresses.
Issues:
Root Cause
GraphQL schema only defined
emailandemail2fields inContactAttrsInput. When Modern UI sentemail3, GraphQL validation rejected it:Solution
Implemented hybrid normalization architecture:
Backend (api-js-client):
email: [String])ContactAttributeChangetype for modify operationsFrontend (zm-x-web):
utils/contacts.jsData Flow:
UI: email, email2, email3
↓
denormalize GraphQL: email: ["a", "b", "c"]
↓
convert SOAP: email, email2, email3
↓
normalize GraphQL: email: ["a", "b", "c"]
↓
normalize UI: email, email2, email3