ZCS-11191: [Backend] Integrate postsrsd#1274
Open
carlosromero03 wants to merge 4 commits intodevelopfrom
Open
Conversation
(cherry picked from commit d7f4e71)
d7f4e71 to
bb62b0b
Compare
silentsakky
reviewed
Nov 25, 2022
|
|
||
|
|
||
| //ZCS-11191 : Allow to enable/disable SRS feature | ||
| public static final KnownKey zimbra_srs_enabled = KnownKey.newKey(false); |
Member
There was a problem hiding this comment.
any reason to put this into LC instead of LDAP? are we planning to release this feature in a patch?
silentsakky
reviewed
Nov 25, 2022
| } | ||
| checkRight(zsc, context, server, attrs); | ||
|
|
||
| startOrStopPostSRSd(server, attrs); |
Member
There was a problem hiding this comment.
is this going to be called with every modifyServer call?
Contributor
There was a problem hiding this comment.
@silentsakky, I think the same this code should not be here, as zmcontrol and all other service's stop/start functionality is written in zm-core-utils repo, which is in Perl script. This logic should also be written in that repo, also would like to confirm the same with @desouzas .
@desouzas : Could you please provide your inputs here? Thanks..!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR has the solution for ZCS-11191, which is about to implement a mechanism to enable/disable the PostSRSd service in Zimbra.
Solution
Notes
Testing Done
This solution can be tested following the next steps: