Merged
Conversation
Zinoex
requested changes
Mar 12, 2025
Owner
Zinoex
left a comment
Zinoex
left a comment
There was a problem hiding this comment.
It's a good first step - I have suggested some changes for you to improve the compatibility of the code and make the code more idiomatic.
It would be great if you could add accessor methods (e.g. getindex(dfa::DFA, z::Int, w::Int) or the same with a string letter) and test them to ensure correctness :-)
Zinoex
approved these changes
Mar 24, 2025
Owner
Zinoex
left a comment
Zinoex
left a comment
There was a problem hiding this comment.
I only have very minor comments about naming :-)
JeffersonYeh
changed the title
JeffersonYeh
force-pushed
the
prod-dfa
branch
3 times, most recently
from
6a60cd7 to
a937b90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds classes used for ProductIMDP value iteration including: