feat: Add schema validation for configuration #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added JSON schema validation in HelmValuesConfig.from_dict - Created test_schema_validation.py with comprehensive tests - Updated tasks.md to reflect completed schema validation tasks - Improved error messages for validation failures
- Add metadata property to return ConfigMetadata instance - Update tests to use ConfigMetadata properties directly - Improve test coverage in test_to_dict_from_dict - Maintain backward compatibility
ritwik-g
commented
Feb 17, 2025
ritwik-g
commented
Feb 17, 2025
ritwik-g
commented
Feb 17, 2025
1. Replace standard logging module with HelmLogger 2. Make HelmLogger imports consistent 3. Add debug logs for key operations 4. Fix test assertions to match error messages
- Update Value class to support multiple data types - Modify ValueBackend and SimpleValueBackend to handle new types - Add test cases for type validation and handling - Improve docstrings with type information
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Part of #4
Changes Made
HelmValuesConfig.from_dicttest_schema_validation.pywith comprehensive tests for:Testing Done
Checklist
Type of Change
Breaking Change
Additional Information
The schema validation ensures that configuration files are valid before they are used, preventing runtime errors due to invalid configuration. The validation is comprehensive and provides clear error messages to help users fix configuration issues.