feat: implement command registry and init command #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed config_file option from init command 2. Converted test_base_command.py from class-based to function-based tests 3. Renamed TestCommand to DummyCommand in test_registry.py to avoid warnings 4. Updated test assertions to match new command output
1. Move command registry initialization into init function to fix test interference 2. Use tmp_path for better test isolation 3. Add proper validation for release name 4. Improve error handling and logging 5. Update tests to verify file creation and content 6. Update tasks.md to mark completed tasks 7. Fix linting issues: - Remove trailing whitespace - Fix docstring formatting - Remove unused imports This change improves test reliability by: - Moving command registration into init function to avoid test interference - Using tmp_path for proper test isolation - Adding better assertions for file operations - Improving error handling and logging
1. Use Optional[HelmValuesConfig] for better type safety 2. Rename local config variable to new_config to avoid shadowing 3. Add missing typing import This change improves code quality by: - Using proper type hints for better IDE support - Avoiding variable shadowing for better readability - Following Python type hinting best practices
1. Remove command registry implementation 2. Update CLI to use direct command instantiation 3. Add ADR-008 documenting the decision 4. Update ADR index This change simplifies our code by removing unnecessary abstraction. See ADR-008 for detailed rationale.
1. Add test for empty release name error 2. Add test for already initialized error 3. Achieve 100% coverage for CLI error handling This ensures all error paths are properly tested and maintains our high test coverage standards.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
No direct issues, part of the CLI command system implementation.
Changes Made
Command Registry Implementation:
Init Command Implementation:
CLI Integration:
Testing Done
Checklist
Type of Change
Breaking Change
Additional Information
This PR implements the command registry system and the first command (init) for the helm-values-manager plugin. The command registry provides a flexible foundation for adding more commands, while the init command gives users the ability to create new helm-values configurations.