Implement set-value command #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add set-value command to CLI interface - Implement SetValueCommand class for setting values for paths and deployments - Add unit tests for the set-value command - Add integration tests for the set-value command - Update tasks.md to mark set-value command as completed - Add standardize-terminology.md for future terminology standardization
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Related Issues
Part of #6
Changes Made
Testing Done
Checklist
Type of Change
Breaking Change
Additional Information
The set-value command allows users to set values for specific paths and deployments. The command follows the existing patterns in the codebase and maintains consistent terminology with other commands. A future PR will standardize all terminology from 'environment' to 'deployment' throughout the codebase.
PR Type
Enhancement, Tests, Documentation
Description
Added
set-valuecommand to CLI for setting configuration values.Implemented
SetValueCommandclass with validation and error handling.Added unit and integration tests for
set-valuefunctionality.Updated documentation and task tracking for the new command.
Changes walkthrough 📝
cli.py
Add `set-value` command to CLIhelm_values_manager/cli.py
set-valuecommand to CLI interface.SetValueCommandfor execution.set_value_command.py
Implement `SetValueCommand` class with validationhelm_values_manager/commands/set_value_command.py
SetValueCommandclass for setting values.test_cli_integration.py
Add integration tests for `set-value` commandtests/integration/test_cli_integration.py
set-valuecommand.test_set_value_command.py
Add unit tests for `SetValueCommand`tests/unit/commands/test_set_value_command.py
SetValueCommand.test_cli.py
Add unit tests for `set-value` CLI commandtests/unit/test_cli.py
set-valueCLI command.standardize-terminology.md
Document terminology standardization plandocs/Development/standardize-terminology.md
tasks.md
Update task tracking for `set-value` and terminologydocs/Development/tasks.md
set-valuecommand completion.