-
Notifications
You must be signed in to change notification settings - Fork 1
[feat] Add generate command and prepare for 0.1.0 release #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update all commands from 'helm values' to 'helm values-manager' - Add mandatory and optional flags for all commands - Fix command flag format for consistency - Update flag names (--env to --deployment) - Add descriptive values for flags
- Add generate command to create values files for deployments - Add pyyaml dependency for YAML file generation - Update CLI with generate command and flags - Add integration tests for generate command - Update test plugin script with generate command tests - Update sequence diagrams with correct command flags The generate command allows users to create values.yaml files for specific deployments, with support for custom output paths. Required values are validated before generation.
- Add clear problem statement to README - Update quick start with complete MVP examples - Fix string formatting in base.py error message
- Bump version to 0.1.0 for initial release - Use importlib.metadata to get version from pyproject.toml - Remove redundant version definitions
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
- Update test_generate_with_none_value to match actual file open parameters - Account for ./ prefix in file path - Include UTF-8 encoding in file open assertion - Add more specific assertions for YAML structure The test was failing in Python 3.13 due to stricter mock assertions, but the underlying functionality was working correctly.
|



User description
Related Issues
Fixes #6
Changes Made
generatecommand to create values files for specific deploymentsTesting Done
Checklist
Type of Change
Breaking Change
Additional Information
This PR completes the MVP feature set for the initial 0.1.0 release. The generate command allows users to create values.yaml files for their deployments with proper validation of required values.
PR Type
Enhancement, Tests, Documentation
Description
Added
generatecommand to create validated YAML files.Enhanced CLI with new commands and options for better usability.
Updated documentation with examples, problem statements, and sequence diagrams.
Comprehensive tests for
generatecommand, including unit, integration, and error handling.Changes walkthrough 📝
3 files
Updated version management using `importlib.metadata`.Added `generate` command to CLI.Implemented `GenerateCommand` for YAML file generation.1 files
Improved error message formatting for invalid auth types.4 files
Added integration tests for `generate` command.Added unit tests for `GenerateCommand`.Added CLI tests for `generate` command.Enhanced test script with `generate` command tests and cleanup.2 files
Set package-ecosystem to `pip` for Dependabot.Updated plugin version to `0.1.0`.2 files
Updated README withgeneratecommand examples and problem statement.Updated sequence diagrams with `generate` command and correct flags.1 files
Updated project version to `0.1.0` and added `pyyaml` dependency.