Update paper repo & add loging on invalid PlaceholderAPIObjective parse#52
Open
JorisvD01 wants to merge 6 commits intoZithium-Studios:mainfrom
Open
Update paper repo & add loging on invalid PlaceholderAPIObjective parse#52JorisvD01 wants to merge 6 commits intoZithium-Studios:mainfrom
JorisvD01 wants to merge 6 commits intoZithium-Studios:mainfrom
Conversation
…se instead of silently skipping
# Conflicts: # build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We've figured out what the issue was for #51, and it was due to the placeholder containing a formatted value (e.g. 1,101) instead of raw (1101) which could not be parsed leading to it silently skipping over the iteration. While this is probably indended behaviour, this PR adds a small log to console to inform any people running into this if this is happening.
Also, updated the paper repo url since that was outdated (copy of #50)