Skip to content

Fixed auth issue #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fixed auth issue #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cache/extra_course_data_cache.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,5 +1062,13 @@
"33337": {
"credits": "1.00",
"prereqs": ""
},
"34975": {
"credits": "1.00 TO 12.00",
"prereqs": ""
},
"34979": {
"credits": "1.00 TO 12.00",
"prereqs": ""
}
}
2 changes: 1 addition & 1 deletion src/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def login_with_drexel_connect(session: Session) -> Session:
# changed easily if the site changes

with sync_playwright() as p:
browser = p.chromium.launch()
browser = p.chromium.launch(headless=True)
context = browser.new_context()
page = context.new_page()
page.goto("https://connect.drexel.edu")
Expand Down
22 changes: 8 additions & 14 deletions src/scrape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,21 @@ def scrape(
reset_period *= 2
try:
session = login.login_with_drexel_connect(session)
if "shib_idp_session" in session.cookies:
is_logged_into_drexel_connect = True
break
else:
print(
f"shib_idp_session cookie not found in session. Trying again in {reset_period} seconds..."
)
is_logged_into_drexel_connect = True
except Exception:
print("Error logging in to Drexel Connect: ")
# not printing stack trace in case password gets accidentally logged
print(f"Trying again in {reset_period} seconds...")

failiure_count += 1
if failiure_count > 8:
raise Exception(
"Failed to log in to Drexel Connect after {} attempts".format(
failiure_count
failiure_count += 1
if failiure_count > 8:
raise Exception(
"Failed to log in to Drexel Connect after {} attempts".format(
failiure_count
)
)
)

time.sleep(reset_period)
time.sleep(reset_period)

data: dict[str, dict[str, Any]] = {}

Expand Down