Fix default All zone creation to account for monitor rotation #4529
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new monitor with Orientation set to ROTATE_90 or ROTATE_270, the default "All" zone dimensions are now correctly swapped to match the rotated image dimensions. This prevents zm_zone.cpp from reporting that zones extend outside of image dimensions and having to fix them at runtime. Fixes issue where monitors created with Rotate Right or Rotate Left would generate warnings like: "Zone 1/All for monitor X extends outside of image dimensions, (0,0), (3839,2159) != (2160,3840), fixing" Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new monitor with Orientation set to ROTATE_90 or ROTATE_270, the default "All" zone dimensions are now correctly swapped to match the rotated image dimensions. This prevents zm_zone.cpp from reporting that zones extend outside of image dimensions and having to fix them at runtime.
Fixes issue where monitors created with Rotate Right or Rotate Left would generate warnings like:
"Zone 1/All for monitor X extends outside of image dimensions, (0,0), (3839,2159) != (2160,3840), fixing"
Also you can see it when you look at the All zone below, the zone is wrong orientation and extends beyond image range. Editing the zone will bring it back to a square.