Fix: Read from 'zmWatchMuted' cookies instead of 'zmWatchMute' on Watch page#4713
Merged
connortechnology merged 2 commits intoZoneMinder:masterfrom Mar 21, 2026
Merged
Conversation
Because we store 'zmWatchMuted' in cookies, not 'zmWatchMute' We can pass 'on' or 'off' to the "controlMute" function, but we store a Boolean value in cookies, so we need to convert it. Also, if there's no cookie, getCookie will return "null," but for us, that doesn't equal "false."
… (watch.js) When starting a stream on the Watch page, don't execute controlMute(), as this will cause the icon to be displayed before the stream actually starts playing. We'll just set the "muted" property for the stream. We'll manage the icon later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we store 'zmWatchMuted' in cookies, not 'zmWatchMute'
We can pass 'on' or 'off' to the "controlMute" function, but we store a Boolean value in cookies, so we need to convert it. Also, if there's no cookie, getCookie will return "null," but for us, that doesn't equal "false."When starting a stream on the Watch page, don't execute controlMute(), as this will cause the icon to be displayed before the stream actually starts playing.
We'll just set the "muted" property for the stream.
We'll manage the icon later.